Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757381AbcJTMPr (ORCPT ); Thu, 20 Oct 2016 08:15:47 -0400 Received: from mail-qt0-f172.google.com ([209.85.216.172]:33889 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753881AbcJTMPp (ORCPT ); Thu, 20 Oct 2016 08:15:45 -0400 MIME-Version: 1.0 In-Reply-To: <1476290430-19542-1-git-send-email-benjamin.tissoires@redhat.com> References: <1476290430-19542-1-git-send-email-benjamin.tissoires@redhat.com> From: Linus Walleij Date: Thu, 20 Oct 2016 14:15:44 +0200 Message-ID: Subject: Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get() To: Benjamin Tissoires Cc: Alexandre Courbot , Mika Westerberg , David Arcari , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 600 Lines: 19 On Wed, Oct 12, 2016 at 6:40 PM, Benjamin Tissoires wrote: > From: David Arcari > > acpi_dev_gpio_irq_get() currently ignores the error returned > by acpi_get_gpiod_by_index() and overwrites it with -ENOENT. > > Problem is this error can be -EPROBE_DEFER, which just blows > up some drivers when the module ordering is not correct. > > Cc: stable@vger.kernel.org > Signed-off-by: David Arcari > Signed-off-by: Benjamin Tissoires Patch applied for fixes with Mika's ACK. Yours, Linus Walleij