Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936469AbcJTM4i (ORCPT ); Thu, 20 Oct 2016 08:56:38 -0400 Received: from mga01.intel.com ([192.55.52.88]:54994 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935062AbcJTM4h (ORCPT ); Thu, 20 Oct 2016 08:56:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,371,1473145200"; d="scan'208";a="21710455" From: "Dalessandro, Dennis" To: "dledford@redhat.com" , "pmladek@suse.com" , "Hefty, Sean" CC: "hal.rosenstock@gmail.com" , "tj@kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/2] IB/rdmavt: cq ktrhead worker fix and API update Thread-Topic: [PATCH 0/2] IB/rdmavt: cq ktrhead worker fix and API update Thread-Index: AQHSKgF1BYPnCYIrHkaynlZbkC4S4qCxs0kA Date: Thu, 20 Oct 2016 12:56:27 +0000 Message-ID: <1476968182.23693.14.camel@intel.com> References: <1476878840-14548-1-git-send-email-pmladek@suse.com> In-Reply-To: <1476878840-14548-1-git-send-email-pmladek@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.182.178] Content-Type: text/plain; charset="utf-8" Content-ID: <70F73D826CF8E24AB6F0756B491B815C@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9KCuhgu025558 Content-Length: 802 Lines: 23 On Wed, 2016-10-19 at 14:07 +0200, Petr Mladek wrote: > The kthread worker API has been improved in 4.9-rc1. The 2nd > patch uses the new functions and simplifies the kthread worker > creation and destroying. > > I have found a possible race when working on the API conversion. > A proposed fix is in the 1st patch. > > Both changes are compile tested only. I did not find an easy way > how to test them at runtime. > > Petr Mladek (2): >   IB/rdmavt: Avoid queuing work into a destroyed cq kthread worker >   IB/rdmavt: Handle the kthread worker using the new API > >  drivers/infiniband/sw/rdmavt/cq.c | 64 +++++++++++++++++---------- > ------------ >  1 file changed, 27 insertions(+), 37 deletions(-) Thanks for the patches. I'm going to take a closer look, I just now seen these. -Denny