Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938553AbcJTNNQ (ORCPT ); Thu, 20 Oct 2016 09:13:16 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33352 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932211AbcJTNNP (ORCPT ); Thu, 20 Oct 2016 09:13:15 -0400 Subject: Re: [PATCH 17/37] staging:r8188eu: update pkt->data synchronously with rx_data To: Dan Carpenter References: <1476889685-7367-1-git-send-email-insafonov@gmail.com> <1476889685-7367-17-git-send-email-insafonov@gmail.com> <20161020090334.GP4469@mwanda> Cc: Greg Kroah-Hartman , Bhaktipriya Shridhar , Geliang Tang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ivan Safonov Message-ID: Date: Thu, 20 Oct 2016 20:15:57 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161020090334.GP4469@mwanda> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 504 Lines: 17 On 10/20/2016 04:03 PM, Dan Carpenter wrote: > On Wed, Oct 19, 2016 at 10:07:45PM +0700, Ivan Safonov wrote: >> To replace rx_data with pkt->data. >> Now pkt->data is equal to rx_data. >> > > I'm not smart enough to tell on my own... Is this a bugfix? It is not bugfix, only variable replacement. recv_frame structure duplicates sk_buff. Most of the ieee80211_* functions require a pointer to sk_buff. Therefore, easier to use sk_buff instead of recv_frame structure. > > regards, > dan carpenter >