Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755498AbcJTObC (ORCPT ); Thu, 20 Oct 2016 10:31:02 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:36578 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900AbcJTObA (ORCPT ); Thu, 20 Oct 2016 10:31:00 -0400 MIME-Version: 1.0 In-Reply-To: <50a2c9fe665c794dc97f524cacb63dc83d3efaa2.1476196031.git-series.maxime.ripard@free-electrons.com> References: <50a2c9fe665c794dc97f524cacb63dc83d3efaa2.1476196031.git-series.maxime.ripard@free-electrons.com> From: Chen-Yu Tsai Date: Thu, 20 Oct 2016 22:30:36 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/9] clk: sunxi-ng: Remove the use of rational computations To: Maxime Ripard Cc: Mike Turquette , Stephen Boyd , Chen-Yu Tsai , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi , Andre Przywara Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 44 On Tue, Oct 11, 2016 at 10:28 PM, Maxime Ripard wrote: > While the rational library works great, it doesn't really allow us to add > more constraints, like the minimum. > > Remove that in order to be able to deal with the constraints we'll need. > > Signed-off-by: Maxime Ripard > --- > drivers/clk/sunxi-ng/Kconfig | 3 +-- > drivers/clk/sunxi-ng/ccu_nkm.c | 31 +++++++++----------- > drivers/clk/sunxi-ng/ccu_nkmp.c | 45 +++++++++++++--------------- > drivers/clk/sunxi-ng/ccu_nm.c | 54 +++++++++++++++++++++++++--------- > 4 files changed, 78 insertions(+), 55 deletions(-) > [...] > diff --git a/drivers/clk/sunxi-ng/ccu_nkmp.c b/drivers/clk/sunxi-ng/ccu_nkmp.c > index 9769dee99511..4b457d8cce11 100644 > --- a/drivers/clk/sunxi-ng/ccu_nkmp.c > +++ b/drivers/clk/sunxi-ng/ccu_nkmp.c > @@ -9,16 +9,15 @@ > */ > > #include > -#include > > #include "ccu_gate.h" > #include "ccu_nkmp.h" > > struct _ccu_nkmp { > - unsigned long n, max_n; > - unsigned long k, max_k; > - unsigned long m, max_m; > - unsigned long p, max_p; > + unsigned long n, min_n, max_n; > + unsigned long k, min_k, max_k; > + unsigned long m, min_m, max_m; > + unsigned long p, min_p, max_p; Wrong patch? Otherwise, Acked-by: Chen-Yu Tsai