Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941138AbcJTPrY (ORCPT ); Thu, 20 Oct 2016 11:47:24 -0400 Received: from slow1-d.mail.gandi.net ([217.70.178.86]:46444 "EHLO slow1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933642AbcJTPrU (ORCPT ); Thu, 20 Oct 2016 11:47:20 -0400 X-Originating-IP: 50.39.170.172 Date: Thu, 20 Oct 2016 08:38:53 -0700 From: Josh Triplett To: Richard Cochran Cc: Nicolas Pitre , John Stultz , Yann E MORIN , Thomas Gleixner , netdev@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ptp_clock: allow for it to be optional Message-ID: <20161020153853.jsvelztvr3bnlqmv@jtriplet-mobl2.jf.intel.com> References: <1476920573-14384-1-git-send-email-nicolas.pitre@linaro.org> <1476920573-14384-4-git-send-email-nicolas.pitre@linaro.org> <20161020140601.GC2238@netboy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161020140601.GC2238@netboy> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 461 Lines: 12 On Thu, Oct 20, 2016 at 04:06:02PM +0200, Richard Cochran wrote: > On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > > +static inline void ptp_clock_event(struct ptp_clock *ptp, > > + struct ptp_clock_event *event) > > +{ (void)event; } > > Just out of curiosity, why do you need that cast? > > (I thought the kernel's gcc settings don't enable the warning for > unused arguments.) And if they did, wouldn't you need it for ptp as well?