Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938856AbcJTQGC (ORCPT ); Thu, 20 Oct 2016 12:06:02 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:45970 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934203AbcJTQGA (ORCPT ); Thu, 20 Oct 2016 12:06:00 -0400 Subject: Re: [PATCH v2 1/6] clk: stm32f4: Add LSI & LSE clocks To: Stephen Boyd References: <1476436699-21879-1-git-send-email-gabriel.fernandez@st.com> <1476436699-21879-2-git-send-email-gabriel.fernandez@st.com> <20161019202433.GA8871@codeaurora.org> CC: Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Nicolas Pitre , Arnd Bergmann , , , , , , , , From: Gabriel Fernandez Message-ID: <2e6e123e-4bb8-951c-9d49-4cb5480c37fd@st.com> Date: Thu, 20 Oct 2016 18:05:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161019202433.GA8871@codeaurora.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-20_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 482 Lines: 18 Hi Stephen, On 10/19/2016 10:24 PM, Stephen Boyd wrote: > On 10/14, gabriel.fernandez@st.com wrote: >> @@ -292,8 +298,110 @@ static int stm32f4_rcc_lookup_clk_idx(u8 primary, u8 secondary) >> return clks[i]; >> } >> >> +static struct regmap *pdrm; > This can't be part of the stm32_rgate structure? Finally i prefer not, because i need also to disable power domain write protection in the patch 4 (clk: stm32f4: Add RTC clock). its will complicate the code. BR Gabriel