Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941462AbcJTQlz (ORCPT ); Thu, 20 Oct 2016 12:41:55 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:35796 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941444AbcJTQlw (ORCPT ); Thu, 20 Oct 2016 12:41:52 -0400 MIME-Version: 1.0 In-Reply-To: <1476914477-25420-3-git-send-email-yao.jin@linux.intel.com> References: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> <1476914477-25420-3-git-send-email-yao.jin@linux.intel.com> From: Nilay Vaish Date: Thu, 20 Oct 2016 11:41:11 -0500 Message-ID: Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain To: Jin Yao Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Linux Kernel list , Andi Kleen , kan.liang@intel.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 747 Lines: 19 On 19 October 2016 at 17:01, Jin Yao wrote: > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h > index 40ecf25..4f6bf6c 100644 > --- a/tools/perf/util/callchain.h > +++ b/tools/perf/util/callchain.h > @@ -115,6 +115,10 @@ struct callchain_list { > bool unfolded; > bool has_children; > }; > + u64 branch_count; > + u64 predicted_count; > + u64 abort_count; Can you explain what abort count is? It seems you are referring to miss-speculated branches. If that is the case, I would prefer that we replace abort by miss_speculated or miss_predicted. -- Nilay