Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941507AbcJTQtW (ORCPT ); Thu, 20 Oct 2016 12:49:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:2323 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932261AbcJTQtV (ORCPT ); Thu, 20 Oct 2016 12:49:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,371,1473145200"; d="scan'208";a="21842652" Date: Thu, 20 Oct 2016 09:48:54 -0700 From: Andi Kleen To: Nilay Vaish Cc: Jin Yao , Arnaldo Carvalho de Melo , Jiri Olsa , Linux Kernel list , kan.liang@intel.com Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain Message-ID: <20161020164854.GB1075@tassilo.jf.intel.com> References: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> <1476914477-25420-3-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 22 On Thu, Oct 20, 2016 at 11:41:11AM -0500, Nilay Vaish wrote: > On 19 October 2016 at 17:01, Jin Yao wrote: > > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h > > index 40ecf25..4f6bf6c 100644 > > --- a/tools/perf/util/callchain.h > > +++ b/tools/perf/util/callchain.h > > @@ -115,6 +115,10 @@ struct callchain_list { > > bool unfolded; > > bool has_children; > > }; > > + u64 branch_count; > > + u64 predicted_count; > > + u64 abort_count; > > Can you explain what abort count is? It seems you are referring to > miss-speculated branches. If that is the case, I would prefer that we > replace abort by miss_speculated or miss_predicted. abort refers to TSX aborts. It has nothing to do with branch mispredictions. -Andi