Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933841AbcJTRHG (ORCPT ); Thu, 20 Oct 2016 13:07:06 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:35064 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933416AbcJTRHD (ORCPT ); Thu, 20 Oct 2016 13:07:03 -0400 MIME-Version: 1.0 In-Reply-To: <20161020164854.GB1075@tassilo.jf.intel.com> References: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> <1476914477-25420-3-git-send-email-yao.jin@linux.intel.com> <20161020164854.GB1075@tassilo.jf.intel.com> From: Nilay Vaish Date: Thu, 20 Oct 2016 12:06:22 -0500 Message-ID: Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain To: Andi Kleen Cc: Jin Yao , Arnaldo Carvalho de Melo , Jiri Olsa , Linux Kernel list , kan.liang@intel.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1588 Lines: 39 On 20 October 2016 at 11:48, Andi Kleen wrote: > On Thu, Oct 20, 2016 at 11:41:11AM -0500, Nilay Vaish wrote: >> On 19 October 2016 at 17:01, Jin Yao wrote: >> > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h >> > index 40ecf25..4f6bf6c 100644 >> > --- a/tools/perf/util/callchain.h >> > +++ b/tools/perf/util/callchain.h >> > @@ -115,6 +115,10 @@ struct callchain_list { >> > bool unfolded; >> > bool has_children; >> > }; >> > + u64 branch_count; >> > + u64 predicted_count; >> > + u64 abort_count; >> >> Can you explain what abort count is? It seems you are referring to >> miss-speculated branches. If that is the case, I would prefer that we >> replace abort by miss_speculated or miss_predicted. > > abort refers to TSX aborts. It has nothing to do with branch > mispredictions. OK, I am more confused now. Are you predicting some quantity related to transactions? Why would you divide abort count by branch count? Further, I just looked at patch 6/6. It has the following text: + Also show with some branch flags that can be: + - Predicted: display the average percentage of predicated branches. + (predicated number / total number) + - Abort: display the average percentage of abort branches. + (abort number /total number) + - Cycles: cycles in basic block. I think there is inconsistency between what you are suggesting and what the patch has. -- Nilay