Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754354AbcJTRre (ORCPT ); Thu, 20 Oct 2016 13:47:34 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:33399 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbcJTRrb (ORCPT ); Thu, 20 Oct 2016 13:47:31 -0400 Date: Thu, 20 Oct 2016 13:47:29 -0400 (EDT) From: Nicolas Pitre To: Thomas Gleixner cc: John Stultz , Richard Cochran , Yann E MORIN , Josh Triplett , netdev@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ptp_clock: allow for it to be optional In-Reply-To: Message-ID: References: <1476920573-14384-1-git-send-email-nicolas.pitre@linaro.org> <1476920573-14384-4-git-send-email-nicolas.pitre@linaro.org> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1998 Lines: 38 On Thu, 20 Oct 2016, Thomas Gleixner wrote: > On Wed, 19 Oct 2016, Nicolas Pitre wrote: > > The pch_gbe driver is a bit special as it relies on extra code in > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > > drivers/ptp/ even if PTP_1588_CLOCK is unselected. > > The above paragraph looks like a leftover of the previous patch set. Not really. Without the change to drivers/Makefile, drivers/ptp/ is not visited when CONFIG_PTP_1588_CLOCK=n. If you then have CONFIG_PCH_GBE=y you end up with: drivers/built-in.o: In function `pch_gbe_ioctl': pch_gbe_main.c:(.text+0x28c914): undefined reference to `pch_ch_control_write' pch_gbe_main.c:(.text+0x28c945): undefined reference to `pch_set_station_address' pch_gbe_main.c:(.text+0x28c964): undefined reference to `pch_ch_event_write' pch_gbe_main.c:(.text+0x28c9ae): undefined reference to `pch_ch_control_write' pch_gbe_main.c:(.text+0x28c9c7): undefined reference to `pch_ch_control_write' pch_gbe_main.c:(.text+0x28c9e6): undefined reference to `pch_ch_control_write' pch_gbe_main.c:(.text+0x28ca17): undefined reference to `pch_set_station_address' drivers/built-in.o: In function `pch_gbe_xmit_frame': pch_gbe_main.c:(.text+0x28ceab): undefined reference to `pch_ch_event_read' pch_gbe_main.c:(.text+0x28cebb): undefined reference to `pch_tx_snap_read' pch_gbe_main.c:(.text+0x28ced8): undefined reference to `pch_ch_event_write' drivers/built-in.o: In function `pch_gbe_napi_poll': pch_gbe_main.c:(.text+0x28da6c): undefined reference to `pch_ch_event_read' pch_gbe_main.c:(.text+0x28da78): undefined reference to `pch_src_uuid_lo_read' pch_gbe_main.c:(.text+0x28da83): undefined reference to `pch_src_uuid_hi_read' pch_gbe_main.c:(.text+0x28db0c): undefined reference to `pch_ch_event_write' pch_gbe_main.c:(.text+0x28df69): undefined reference to `pch_rx_snap_read' pch_gbe_main.c:(.text+0x28df88): undefined reference to `pch_ch_event_write' make: *** [vmlinux] Error 1 Hence the above paragraph. Nicolas