Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756029AbcJTSBW (ORCPT ); Thu, 20 Oct 2016 14:01:22 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49281 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755864AbcJTSBR (ORCPT ); Thu, 20 Oct 2016 14:01:17 -0400 Date: Thu, 20 Oct 2016 19:58:47 +0200 (CEST) From: Thomas Gleixner To: Nicolas Pitre cc: John Stultz , Richard Cochran , Yann E MORIN , Josh Triplett , netdev@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ptp_clock: allow for it to be optional In-Reply-To: Message-ID: References: <1476920573-14384-1-git-send-email-nicolas.pitre@linaro.org> <1476920573-14384-4-git-send-email-nicolas.pitre@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 24 On Thu, 20 Oct 2016, Nicolas Pitre wrote: > On Thu, 20 Oct 2016, Thomas Gleixner wrote: > > > On Wed, 19 Oct 2016, Nicolas Pitre wrote: > > > The pch_gbe driver is a bit special as it relies on extra code in > > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > > > drivers/ptp/ even if PTP_1588_CLOCK is unselected. > > > > The above paragraph looks like a leftover of the previous patch set. > > Not really. Without the change to drivers/Makefile, drivers/ptp/ is not > visited when CONFIG_PTP_1588_CLOCK=n. If you then have CONFIG_PCH_GBE=y > you end up with: > > drivers/built-in.o: In function `pch_gbe_ioctl': > pch_gbe_main.c:(.text+0x28c914): undefined reference to `pch_ch_control_write' > > Hence the above paragraph. Indeed. I misread that. Thanks, tglx