Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932786AbcJTSKj (ORCPT ); Thu, 20 Oct 2016 14:10:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59792 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbcJTSKh (ORCPT ); Thu, 20 Oct 2016 14:10:37 -0400 Date: Thu, 20 Oct 2016 20:10:33 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Wanpeng Li Cc: "linux-kernel@vger.kernel.org" , kvm , Paolo Bonzini , Yunhong Jiang , Wanpeng Li Subject: Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support Message-ID: <20161020181033.GA6375@potion> References: <1476690302-22158-1-git-send-email-wanpeng.li@hotmail.com> <1476690302-22158-6-git-send-email-wanpeng.li@hotmail.com> <20161019192826.GA8573@potion> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 20 Oct 2016 18:10:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 15 2016-10-20 06:57+0800, Wanpeng Li: > 2016-10-20 3:28 GMT+08:00 Radim Krčmář : >> I think it would be better to add a function to advance the periodic >> timer and use it in kvm_lapic_expired_hv_timer() and in apic_timer_fn(). >> >> The function can be simpler than set_target_expiration(), because it >> just adds the period to an existing timer. Periodic timer will also be >> better then, because the period will not depend on KVM's latency when >> rearming. > > Good point, what's the function name do you like? How about > advance_target_expiration()? Sounds good, I'd just slap periodic somewhere, advance_periodic_target_expiration()?