Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933158AbcJTSUj (ORCPT ); Thu, 20 Oct 2016 14:20:39 -0400 Received: from mga07.intel.com ([134.134.136.100]:21389 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932519AbcJTSUi (ORCPT ); Thu, 20 Oct 2016 14:20:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,372,1473145200"; d="scan'208";a="21881076" Date: Thu, 20 Oct 2016 11:20:36 -0700 From: Andi Kleen To: Nilay Vaish Cc: Jin Yao , Arnaldo Carvalho de Melo , Jiri Olsa , Linux Kernel list , kan.liang@intel.com Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain Message-ID: <20161020182036.GC1075@tassilo.jf.intel.com> References: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> <1476914477-25420-3-git-send-email-yao.jin@linux.intel.com> <20161020164854.GB1075@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 20 > OK, I am more confused now. Are you predicting some quantity related > to transactions? Why would you divide abort count by branch count? > Further, I just looked at patch 6/6. It has the following text: > > + Also show with some branch flags that can be: > + - Predicted: display the average percentage of predicated branches. > + (predicated number / total number) > + - Abort: display the average percentage of abort branches. > + (abort number /total number) > + - Cycles: cycles in basic block. > > > I think there is inconsistency between what you are suggesting and > what the patch has. An abort is an unique branch. But yes there is no total number, so the formula will always be 100%. So yes would probably be better to just display a count for abort. -Andi