Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756168AbcJTTeG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Oct 2016 15:34:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55162 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756079AbcJTTeF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Oct 2016 15:34:05 -0400
Date: Thu, 20 Oct 2016 13:34:03 -0600
From: Alex Williamson <alex.williamson@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>
Cc: <pbonzini@redhat.com>, <kraxel@redhat.com>, <cjia@nvidia.com>,
        <qemu-devel@nongnu.org>, <kvm@vger.kernel.org>, <kevin.tian@intel.com>,
        <jike.song@intel.com>, <bjsdjshi@linux.vnet.ibm.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 10/12] vfio: Add function to get device_api string
 from vfio_device_info.flags
Message-ID: <20161020133403.08828f47@t450s.home>
In-Reply-To: <1476739332-4911-11-git-send-email-kwankhede@nvidia.com>
References: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com>
        <1476739332-4911-11-git-send-email-kwankhede@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 20 Oct 2016 19:34:04 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1963
Lines: 60

On Tue, 18 Oct 2016 02:52:10 +0530
Kirti Wankhede <kwankhede@nvidia.com> wrote:

> Function vfio_device_api_string() returns string based on flag set in
> vfio_device_info's flag. This should be used by vendor driver to get string
> based on flag for device_api attribute.
> 
> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
> Signed-off-by: Neo Jia <cjia@nvidia.com>
> Change-Id: I42d29f475f02a7132ce13297fbf2b48f1da10995
> ---
>  drivers/vfio/vfio.c  | 15 +++++++++++++++
>  include/linux/vfio.h |  2 ++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index 10ef1c5fa762..aec470454a13 100644
> --- a/drivers/vfio/vfio.c
> +++ b/drivers/vfio/vfio.c
> @@ -1917,6 +1917,21 @@ int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr, int num_irqs,
>  }
>  EXPORT_SYMBOL(vfio_set_irqs_validate_and_prepare);
>  
> +const char *vfio_device_api_string(u32 flags)
> +{
> +	if (flags & VFIO_DEVICE_FLAGS_PCI)
> +		return "vfio-pci";
> +
> +	if (flags & VFIO_DEVICE_FLAGS_PLATFORM)
> +		return "vfio-platform";
> +
> +	if (flags & VFIO_DEVICE_FLAGS_AMBA)
> +		return "vfio-amba";
> +
> +	return "";
> +}
> +EXPORT_SYMBOL(vfio_device_api_string);
> +
>  /*
>   * Pin a set of guest PFNs and return their associated host PFNs for local
>   * domain only.
> diff --git a/include/linux/vfio.h b/include/linux/vfio.h
> index 31d059f1649b..fca2bf23c4f1 100644
> --- a/include/linux/vfio.h
> +++ b/include/linux/vfio.h
> @@ -116,6 +116,8 @@ extern int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr,
>  					      int num_irqs, int max_irq_type,
>  					      size_t *data_size);
>  
> +extern const char *vfio_device_api_string(u32 flags);
> +
>  struct pci_dev;
>  #ifdef CONFIG_EEH
>  extern void vfio_spapr_pci_eeh_open(struct pci_dev *pdev);

Couldn't this simply be a #define in the uapi header?

#define VFIO_DEVICE_PCI_API_STRING "vfio-pci"

I don't really see why we need a lookup function.