Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933131AbcJTTvg (ORCPT ); Thu, 20 Oct 2016 15:51:36 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44485 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932694AbcJTTve (ORCPT ); Thu, 20 Oct 2016 15:51:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org B78A761B2E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH] acpi/apei: Fix in-correct return value To: Punit Agrawal , linux-acpi@vger.kernel.org, rjw@rjwysocki.net References: <20161018160719.31252-1-punit.agrawal@arm.com> Cc: linux-kernel@vger.kernel.org, bp@suse.de, Len Brown From: "Baicar, Tyler" Message-ID: Date: Thu, 20 Oct 2016 13:51:31 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161018160719.31252-1-punit.agrawal@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 34 On 10/18/2016 10:07 AM, Punit Agrawal wrote: > Although ghes_proc tests for error while reading the error status, it > always return success (0). Fix this by propagating the return value. > > Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support") > Signed-of-by: Punit Agrawal > Cc: "Rafael J. Wysocki" > Cc: Len Brown Tested-by: Tyler Baicar Thanks, Tyler > --- > drivers/acpi/apei/ghes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index f0a029e..0d099a2 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes) > ghes_do_proc(ghes, ghes->estatus); > out: > ghes_clear_estatus(ghes); > - return 0; > + return rc; > } > > static void ghes_add_timer(struct ghes *ghes) -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.