Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756409AbcJTVSi (ORCPT ); Thu, 20 Oct 2016 17:18:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59130 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756164AbcJTVSf (ORCPT ); Thu, 20 Oct 2016 17:18:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 5F52061B8A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=spjoshi@codeaurora.org Subject: Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes To: Bjorn Andersson References: <1476989765-7524-1-git-send-email-spjoshi@codeaurora.org> <1476989765-7524-3-git-send-email-spjoshi@codeaurora.org> <20161020195629.GM7509@tuxbot> Cc: Andy Gross , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Boyd , Trilok Soni From: Sarangdhar Joshi Message-ID: <1c7504f2-48ca-bcae-3eef-16589513d1aa@codeaurora.org> Date: Thu, 20 Oct 2016 14:18:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161020195629.GM7509@tuxbot> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1889 Lines: 70 On 10/20/2016 12:56 PM, Bjorn Andersson wrote: > On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote: > >> From: Bjorn Andersson >> >> Add SMEM and TCSR DT nodes on MSM8996. >> >> Signed-off-by: Bjorn Andersson >> Signed-off-by: Sarangdhar Joshi >> --- >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> index 949b096..0a810f5 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> @@ -169,12 +169,31 @@ >> method = "smc"; >> }; >> >> + smem { >> + compatible = "qcom,smem"; >> + >> + memory-region = <&smem_mem>; >> + >> + hwlocks = <&tcsr_mutex 3>; >> + }; >> + >> soc: soc { >> #address-cells = <1>; >> #size-cells = <1>; >> ranges = <0 0 0 0xffffffff>; >> compatible = "simple-bus"; >> >> + tcsr_mutex_regs: syscon@740000 { >> + compatible = "syscon"; >> + reg = <0x740000 0x20000>; >> + }; >> + >> + tcsr_mutex: hwlock { >> + compatible = "qcom,tcsr-mutex"; >> + syscon = <&tcsr_mutex_regs 0 0x1000>; >> + #hwlock-cells = <1>; >> + }; > > Sorry, I got this in the wrong place, the hwlock node should sit outside > of soc {} - looks like we got this wrong in msm8916 as well. Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e. root)? > > Regards, > Bjorn > >> + >> intc: interrupt-controller@9bc0000 { >> compatible = "arm,gic-v3"; >> #interrupt-cells = <3>; >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project >> Regards, Sarang -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project