Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756842AbcJTVWh (ORCPT ); Thu, 20 Oct 2016 17:22:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60847 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756403AbcJTVWc (ORCPT ); Thu, 20 Oct 2016 17:22:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 9317361822 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=spjoshi@codeaurora.org Subject: Re: [PATCH 4/4] arm64: dts: msm8996: Add SMP2P and APCS nodes To: Bjorn Andersson References: <1476989765-7524-1-git-send-email-spjoshi@codeaurora.org> <1476989765-7524-4-git-send-email-spjoshi@codeaurora.org> <20161020200304.GP7509@tuxbot> Cc: Mark Rutland , devicetree@vger.kernel.org, Catalin Marinas , Trilok Soni , Will Deacon , linux-kernel@vger.kernel.org, David Brown , Rob Herring , linux-arm-msm@vger.kernel.org, Andy Gross , linux-soc@vger.kernel.org, Stephen Boyd , linux-arm-kernel@lists.infradead.org From: Sarangdhar Joshi Message-ID: Date: Thu, 20 Oct 2016 14:22:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161020200304.GP7509@tuxbot> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2506 Lines: 99 On 10/20/2016 01:03 PM, Bjorn Andersson wrote: > On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote: > >> Add SMP2P and APCS DT nodes required for Qualcomm ADSP >> Peripheral Image Loader. >> > > Nice, two (very) small nits below. But other than that > > Acked-by: Bjorn Andersson > > Regards, > Bjorn > >> Signed-off-by: Sarangdhar Joshi >> --- >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> index 0a810f5..3edb56b 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> @@ -169,6 +169,31 @@ >> method = "smc"; >> }; >> >> + smp2p-adsp { > > Sorry for bikeshedding, but on msm8916 I named these {subsystem}-smp2p, > so I would prefer this was naemd adsp-smp2p... Sure. Will do. > >> + compatible = "qcom,smp2p"; >> + qcom,smem = <443>, <429>; >> + >> + interrupt-parent = <&intc>; > > I believe this node inherit intc as interrupt-parent from the root > already, is there are reason why you need to specify it. > Good catch. I will remove it. >> + interrupts = <0 158 IRQ_TYPE_EDGE_RISING>; >> + >> + qcom,ipc = <&apcs 16 10>; >> + >> + qcom,local-pid = <0>; >> + qcom,remote-pid = <2>; >> + >> + adsp_smp2p_out: master-kernel { >> + qcom,entry-name = "master-kernel"; >> + #qcom,state-cells = <1>; >> + }; >> + >> + adsp_smp2p_in: slave-kernel { >> + qcom,entry-name = "slave-kernel"; >> + >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + }; >> + }; >> + >> smem { >> compatible = "qcom,smem"; >> >> @@ -205,6 +230,11 @@ >> interrupts = ; >> }; >> >> + apcs: syscon@9820000 { >> + compatible = "syscon"; >> + reg = <0x9820000 0x1000>; >> + }; >> + >> gcc: clock-controller@300000 { >> compatible = "qcom,gcc-msm8996"; >> #clock-cells = <1>; >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > Thanks for reviewing the patch. Regards, Sarang -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project