Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754926AbcJTWpv (ORCPT ); Thu, 20 Oct 2016 18:45:51 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:54991 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754285AbcJTWpt (ORCPT ); Thu, 20 Oct 2016 18:45:49 -0400 Date: Thu, 20 Oct 2016 16:45:21 -0600 From: Jason Gunthorpe To: Kees Cook Cc: Michael Ellerman , Andrew Morton , Denys Vlasenko , "linuxppc-dev@lists.ozlabs.org" , Benjamin Herrenschmidt , Paul Mackerras , "Aneesh Kumar K.V" , Oleg Nesterov , Florian Weimer , Linux-MM , LKML Subject: Re: [PATCH v6] powerpc: Do not make the entire heap executable Message-ID: <20161020224521.GA24970@obsidianresearch.com> References: <20161003161322.3835-1-dvlasenk@redhat.com> <877f9p55lu.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1856 Lines: 47 On Tue, Oct 04, 2016 at 09:54:12AM -0700, Kees Cook wrote: > On Mon, Oct 3, 2016 at 5:18 PM, Michael Ellerman wrote: > > Kees Cook writes: > > > >> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko wrote: > >>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt, > >>> or with a toolchain which defaults to it) look like this: > > ... > >>> > >>> Signed-off-by: Jason Gunthorpe > >>> Signed-off-by: Denys Vlasenko > >>> Acked-by: Kees Cook > >>> Acked-by: Michael Ellerman > >>> CC: Benjamin Herrenschmidt > >>> CC: Paul Mackerras > >>> CC: "Aneesh Kumar K.V" > >>> CC: Kees Cook > >>> CC: Oleg Nesterov > >>> CC: Michael Ellerman > >>> CC: Florian Weimer > >>> CC: linux-mm@kvack.org > >>> CC: linuxppc-dev@lists.ozlabs.org > >>> CC: linux-kernel@vger.kernel.org > >>> Changes since v5: > >>> * made do_brk_flags() error out if any bits other than VM_EXEC are set. > >>> (Kees Cook: "With this, I'd be happy to Ack.") > >>> See https://patchwork.ozlabs.org/patch/661595/ > >> > >> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree? > > > > -mm would be best, given the diffstat I think it's less likely to > > conflict if it goes via -mm. > > Okay, excellent. Andrew, do you have this already in email? I think > you weren't on the explicit CC from the v6... FWIW (and ping), Tested-by: Jason Gunthorpe On ARM32 (kirkwood) and PPC32 (405) For reference, here is the patchwork URL: https://patchwork.ozlabs.org/patch/677753/ Jason