Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757481AbcJTXBH (ORCPT ); Thu, 20 Oct 2016 19:01:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51764 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753959AbcJTXBF (ORCPT ); Thu, 20 Oct 2016 19:01:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org D7F5761BC7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 20 Oct 2016 16:01:03 -0700 From: Stephen Boyd To: Orson Zhai Cc: mturquette@baylibre.com, baolin.wang@spreadtrum.com, xiaolong.zhang@spreadtrum.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, ben.li@spreadturm.com Subject: Re: [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks Message-ID: <20161020230103.GD26139@codeaurora.org> References: <1476184424-8528-1-git-send-email-orson.zhai@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476184424-8528-1-git-send-email-orson.zhai@spreadtrum.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 21 On 10/11, Orson Zhai wrote: > From: Xiaolong Zhang > > When common kernel setups fixed clock, of_clk_provider will be registerred. > But there is no clkdev being registerred at the same time. This will make > it difficult to get the clock by using clk_get(NULL, con_id). > > Add clkdev register for fixed-rate and fixed-factor clock and ignore > the error if any. > > Signed-off-by: Xiaolong Zhang > Signed-off-by: Orson Zhai > --- Why are we using clkdev lookups for clks populated from DT? Shouldn't we be able to point to them from the consumers that would also be in DT? I'm a little lost. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project