Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753456AbcJTXyF (ORCPT ); Thu, 20 Oct 2016 19:54:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60379 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbcJTXyC (ORCPT ); Thu, 20 Oct 2016 19:54:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org A24C9617BF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 20 Oct 2016 16:54:01 -0700 From: Stephen Boyd To: Sarangdhar Joshi Cc: Ohad Ben-Cohen , Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Trilok Soni Subject: Re: [PATCH] remoteproc: Add support for xo clock Message-ID: <20161020235401.GG26139@codeaurora.org> References: <1476989724-7464-1-git-send-email-spjoshi@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476989724-7464-1-git-send-email-spjoshi@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 748 Lines: 26 On 10/20, Sarangdhar Joshi wrote: > Add xo clock support required for Qualcomm ADSP > Peripheral Image Loader. Yes but why is xo needed? > @@ -223,6 +232,17 @@ static irqreturn_t adsp_stop_ack_interrupt(int irq, void *dev) > return IRQ_HANDLED; > } > > +static int adsp_init_clock(struct qcom_adsp *adsp) > +{ > + adsp->xo = devm_clk_get(adsp->dev, "xo"); > + if (IS_ERR(adsp->xo)) { > + dev_err(adsp->dev, "failed to get xo clock"); What if it's a probe defer error? Probably best to just be silent/debug level, or we need a specific test for EPROBE_DEFER and then silence in that case. > + return PTR_ERR(adsp->xo); > + } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project