Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754872AbcJUAXp (ORCPT ); Thu, 20 Oct 2016 20:23:45 -0400 Received: from mga14.intel.com ([192.55.52.115]:15770 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359AbcJUAXo (ORCPT ); Thu, 20 Oct 2016 20:23:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,521,1473145200"; d="scan'208";a="1056893118" Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain To: Andi Kleen , Nilay Vaish References: <1476914477-25420-1-git-send-email-yao.jin@linux.intel.com> <1476914477-25420-3-git-send-email-yao.jin@linux.intel.com> <20161020164854.GB1075@tassilo.jf.intel.com> <20161020182036.GC1075@tassilo.jf.intel.com> Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Linux Kernel list , kan.liang@intel.com From: "Jin, Yao" Message-ID: <747ba5dc-8015-7634-eb1c-94f82ebb75b1@linux.intel.com> Date: Fri, 21 Oct 2016 08:23:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161020182036.GC1075@tassilo.jf.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 30 Hi Andi, Hi Nilay, Thanks so much for your comments! I will upgrade the patch to just display the count for abort. Thanks Jin Yao On 10/21/2016 2:20 AM, Andi Kleen wrote: >> OK, I am more confused now. Are you predicting some quantity related >> to transactions? Why would you divide abort count by branch count? >> Further, I just looked at patch 6/6. It has the following text: >> >> + Also show with some branch flags that can be: >> + - Predicted: display the average percentage of predicated branches. >> + (predicated number / total number) >> + - Abort: display the average percentage of abort branches. >> + (abort number /total number) >> + - Cycles: cycles in basic block. >> >> >> I think there is inconsistency between what you are suggesting and >> what the patch has. > An abort is an unique branch. But yes there is no total number, > so the formula will always be 100%. So yes would probably be > better to just display a count for abort. > > -Andi