Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753706AbcJUBgI (ORCPT ); Thu, 20 Oct 2016 21:36:08 -0400 Received: from mail.kernel.org ([198.145.29.136]:51460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbcJUBgH (ORCPT ); Thu, 20 Oct 2016 21:36:07 -0400 Date: Fri, 21 Oct 2016 09:35:46 +0800 From: Shawn Guo To: Jagan Teki Cc: devicetree@vger.kernel.org, Matteo Lisi , "linux-kernel@vger.kernel.org" , Jagan Teki , Michael Trimarchi , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Message-ID: <20161021013546.GF30578@tiger> References: <1476437243-13297-1-git-send-email-jteki@openedev.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1449 Lines: 34 On Tue, Oct 18, 2016 at 05:30:28PM +0530, Jagan Teki wrote: > Hi Shawn, > > On Fri, Oct 14, 2016 at 2:57 PM, Jagan Teki wrote: > > This is series add dts support for Engicam I.Core M6 qdl modules. just > > rebased on top of linux-next of previous set[1]. > > > > [1] http://www.spinics.net/lists/kernel/msg2358233.html > > > > Jagan Teki (5): > > ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support > > ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo initial support > > ARM: dts: imx6qdl-icore: Add usbhost support > > ARM: dts: imx6qdl-icore: Add usbotg support > > ARM: dts: imx6qdl-icore: Add FEC support > > > > arch/arm/boot/dts/Makefile | 2 + > > arch/arm/boot/dts/imx6dl-icore.dts | 59 ++++++++ > > arch/arm/boot/dts/imx6q-icore.dts | 59 ++++++++ > > arch/arm/boot/dts/imx6qdl-icore.dtsi | 271 +++++++++++++++++++++++++++++++++++ > > 4 files changed, 391 insertions(+) > > create mode 100644 arch/arm/boot/dts/imx6dl-icore.dts > > create mode 100644 arch/arm/boot/dts/imx6q-icore.dts > > create mode 100644 arch/arm/boot/dts/imx6qdl-icore.dtsi > > Can you pick this series? Sorry for the delay. The first two patches look good, and I had a couple of small comments on the other 3. Also, for the initial board support submission like this, you do not need to split it per device support. That said, please squash the series into one patch when resending. Shawn