Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753849AbcJUDO6 (ORCPT ); Thu, 20 Oct 2016 23:14:58 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:55371 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753228AbcJUDO4 (ORCPT ); Thu, 20 Oct 2016 23:14:56 -0400 Date: Fri, 21 Oct 2016 11:14:50 +0800 From: Herbert Xu To: Eric Biggers Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: cmac - return -EINVAL if block size is unsupported Message-ID: <20161021031450.GH22979@gondor.apana.org.au> References: <1476119715-71397-1-git-send-email-ebiggers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476119715-71397-1-git-send-email-ebiggers@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 14 On Mon, Oct 10, 2016 at 10:15:14AM -0700, Eric Biggers wrote: > cmac_create() previously returned 0 if a cipher with a block size other > than 8 or 16 bytes was specified. It should return -EINVAL instead. > Granted, this doesn't actually change any behavior because cryptomgr > currently ignores any return value other than -EAGAIN from template > ->create() functions. > > Signed-off-by: Eric Biggers Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt