Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932231AbcJUGi7 (ORCPT ); Fri, 21 Oct 2016 02:38:59 -0400 Received: from muru.com ([72.249.23.125]:45516 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115AbcJUGi4 (ORCPT ); Fri, 21 Oct 2016 02:38:56 -0400 Date: Thu, 20 Oct 2016 23:38:52 -0700 From: Tony Lindgren To: Jeroen Hofstee Cc: netdev@vger.kernel.org, Mugunthan V N , Grygorii Strashko , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: cpsw: fix obtaining mac address for am3517 Message-ID: <20161021063851.6frul6pemo52i7ot@atomide.com> References: <1476993351-23065-1-git-send-email-jhofstee@victronenergy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476993351-23065-1-git-send-email-jhofstee@victronenergy.com> User-Agent: Mutt/1.6.2-neo (2016-07-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 497 Lines: 13 * Jeroen Hofstee [161020 12:57]: > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > id to common file") did not only move the code for an am3517, it also > added the slave parameter, resulting in a invalid (all zero) mac address > being returned. So change it back to always read from slave zero, so it > works again. Hmm doesn't this now break it for cpsw with two instances? We may need am3517 specific quirk flag instead? Regards, Tony