Date: Fri, 21 Oct 2016 08:48:19 +0200
From: Ludovic Desroches <ludovic.desroches@atmel.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
CC: <linux-kernel@vger.kernel.org>,
        Ludovic Desroches <ludovic.desroches@atmel.com>,
        <linux-mmc@vger.kernel.org>, Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload
Message-ID: <20161021064819.4y5jrdetrqsvibfa@rfolt0960.corp.atmel.com>
Mail-Followup-To: Javier Martinez Canillas <javier@osg.samsung.com>,
        linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
References: <1476720825-30442-1-git-send-email-javier@osg.samsung.com>
 <1476720825-30442-2-git-send-email-javier@osg.samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1476720825-30442-2-git-send-email-javier@osg.samsung.com>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1364
Lines: 42

On Mon, Oct 17, 2016 at 01:13:45PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
> alias:          of:N*T*Catmel,sama5d2-sdhciC*
> alias:          of:N*T*Catmel,sama5d2-sdhci
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Thanks
> ---
> 
>  drivers/mmc/host/sdhci-of-at91.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index a9b7fc06c434..2f9ad213377a 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
>  	{ .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
>  
>  #ifdef CONFIG_PM
>  static int sdhci_at91_runtime_suspend(struct device *dev)
> -- 
> 2.7.4
>