Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754682AbcJUHGL (ORCPT ); Fri, 21 Oct 2016 03:06:11 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34353 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753106AbcJUHGK (ORCPT ); Fri, 21 Oct 2016 03:06:10 -0400 Subject: Re: [PATCH 1/5] perf core: Introduce new ioctl options to pause and resume ring buffer To: "Wangnan (F)" , Peter Zijlstra References: <1457949585-191064-1-git-send-email-wangnan0@huawei.com> <1457949585-191064-2-git-send-email-wangnan0@huawei.com> <20160323091654.GV6344@twins.programming.kicks-ass.net> <56F26301.3010100@huawei.com> Cc: mtk.manpages@gmail.com, mingo@redhat.com, linux-kernel@vger.kernel.org, He Kuang , Alexei Starovoitov , Arnaldo Carvalho de Melo , Brendan Gregg , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Zefan Li , pi3orama@163.com, Vince Weaver From: "Michael Kerrisk (man-pages)" Message-ID: Date: Fri, 21 Oct 2016 09:06:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <56F26301.3010100@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2109 Lines: 67 Hello Wangnan, The patch below seems to have landed in Linux 4.7, commit 86e7972f690c1017fd086cdfe53d8524e68c661c Could you draft a man-pages patch for this interface change, please? Or, failing that, a plain-text description that we can integrate into the man-page. Thanks, Michael On 03/23/2016 10:33 AM, Wangnan (F) wrote: > > > On 2016/3/23 17:16, Peter Zijlstra wrote: >> On Mon, Mar 14, 2016 at 09:59:41AM +0000, Wang Nan wrote: >>> Add new ioctl() to pause/resume ring-buffer output. >>> >>> In some situations we want to read from ring buffer only when we >>> ensure nothing can write to the ring buffer during reading. Without >>> this patch we have to turn off all events attached to this ring buffer >>> to achieve this. >>> >>> This patch is for supporting overwrite ring buffer. Following >>> commits will introduce new methods support reading from overwrite ring >>> buffer. Before reading caller must ensure the ring buffer is frozen, or >>> the reading is unreliable. >>> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h >>> index 1afe962..a3c1903 100644 >>> --- a/include/uapi/linux/perf_event.h >>> +++ b/include/uapi/linux/perf_event.h >>> @@ -401,6 +401,7 @@ struct perf_event_attr { >>> #define PERF_EVENT_IOC_SET_FILTER _IOW('$', 6, char *) >>> #define PERF_EVENT_IOC_ID _IOR('$', 7, __u64 *) >>> #define PERF_EVENT_IOC_SET_BPF _IOW('$', 8, __u32) >>> +#define PERF_EVENT_IOC_PAUSE_OUTPUT _IOW('$', 9, __u32) > > Glad to see you start to look at this patchset. > > > >> Can you also do a patch to the man-pages? >> >> http://man7.org/linux/man-pages/man2/perf_event_open.2.html > > Sure. > > I think I need to provide a patch for: > > http://git.kernel.org/cgit/docs/man-pages/man-pages.git > > But which one should be the first? Shall we update man pages before > this patch be merged by upstream? Or Michael and Vince will consider > this problem? > > Thank you. > > > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/