Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755071AbcJUH2X (ORCPT ); Fri, 21 Oct 2016 03:28:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:10909 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754533AbcJUH2V (ORCPT ); Fri, 21 Oct 2016 03:28:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,375,1473145200"; d="scan'208";a="1073592884" Subject: Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload To: Javier Martinez Canillas , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Ulf Hansson References: <1476720825-30442-1-git-send-email-javier@osg.samsung.com> <1476720825-30442-2-git-send-email-javier@osg.samsung.com> <20161021064819.4y5jrdetrqsvibfa@rfolt0960.corp.atmel.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <488cd9f4-1522-6346-6618-0f3168badf96@intel.com> Date: Fri, 21 Oct 2016 10:23:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161021064819.4y5jrdetrqsvibfa@rfolt0960.corp.atmel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1500 Lines: 47 On 21/10/16 09:48, Ludovic Desroches wrote: > On Mon, Oct 17, 2016 at 01:13:45PM -0300, Javier Martinez Canillas wrote: >> If the driver is built as a module, autoload won't work because the module >> alias information is not filled. So user-space can't match the registered >> device with the corresponding module. >> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. >> >> Before this patch: >> >> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias >> $ >> >> After this patch: >> >> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias >> alias: of:N*T*Catmel,sama5d2-sdhciC* >> alias: of:N*T*Catmel,sama5d2-sdhci >> >> Signed-off-by: Javier Martinez Canillas > Acked-by: Ludovic Desroches Acked-by: Adrian Hunter > > Thanks >> --- >> >> drivers/mmc/host/sdhci-of-at91.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c >> index a9b7fc06c434..2f9ad213377a 100644 >> --- a/drivers/mmc/host/sdhci-of-at91.c >> +++ b/drivers/mmc/host/sdhci-of-at91.c >> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = { >> { .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 }, >> {} >> }; >> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match); >> >> #ifdef CONFIG_PM >> static int sdhci_at91_runtime_suspend(struct device *dev) >> -- >> 2.7.4 >> >