Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640AbcJUHxY (ORCPT ); Fri, 21 Oct 2016 03:53:24 -0400 Received: from muru.com ([72.249.23.125]:45609 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbcJUHxW (ORCPT ); Fri, 21 Oct 2016 03:53:22 -0400 Date: Fri, 21 Oct 2016 00:53:18 -0700 From: Tony Lindgren To: Jeroen Hofstee Cc: netdev@vger.kernel.org, Mugunthan V N , Grygorii Strashko , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: cpsw: fix obtaining mac address for am3517 Message-ID: <20161021075317.767cu7qkmcn4k4e4@atomide.com> References: <1476993351-23065-1-git-send-email-jhofstee@victronenergy.com> <20161021063851.6frul6pemo52i7ot@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-07-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 31 * Jeroen Hofstee [161021 00:37]: > Hello Tony, > > On 21-10-16 08:38, Tony Lindgren wrote: > > * Jeroen Hofstee [161020 12:57]: > > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > > > id to common file") did not only move the code for an am3517, it also > > > added the slave parameter, resulting in a invalid (all zero) mac address > > > being returned. So change it back to always read from slave zero, so it > > > works again. > > Hmm doesn't this now break it for cpsw with two instances? > > > > Yes, well, they get the same mac address at least. But does it matter? > This changes davinci_emac_3517_get_macid, the only way to get there > is: > > if (of_device_is_compatible(dev->of_node, "ti,am3517-emac")) > return davinci_emac_3517_get_macid(dev, 0x110, slave, mac_addr) > > and the only user of ti,am3517-emac is arch/arm/boot/dts/am3517.dtsi, > which only has one emac. So the change is already am3517 specific. > > > We may need am3517 specific quirk flag instead? > > Given above, it is already am3517 specific. Let me know if you prefer this > route then I will have a look at it. Oh OK thanks for explaining it :) As it's already am3517 specific: Acked-by: Tony Lindgren