Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754206AbcJUHz5 (ORCPT ); Fri, 21 Oct 2016 03:55:57 -0400 Received: from s159.web-hosting.com ([68.65.120.118]:56071 "EHLO s159.web-hosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbcJUHzz (ORCPT ); Fri, 21 Oct 2016 03:55:55 -0400 MIME-Version: 1.0 In-Reply-To: <20161021013546.GF30578@tiger> References: <1476437243-13297-1-git-send-email-jteki@openedev.com> <20161021013546.GF30578@tiger> From: Jagan Teki Date: Fri, 21 Oct 2016 13:25:49 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts To: Shawn Guo Cc: devicetree@vger.kernel.org, Matteo Lisi , "linux-kernel@vger.kernel.org" , Michael Trimarchi , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server159.web-hosting.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - openedev.com X-Get-Message-Sender-Via: server159.web-hosting.com: authenticated_id: jagan@openedev.com X-Authenticated-Sender: server159.web-hosting.com: jagan@openedev.com X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1967 Lines: 46 On Fri, Oct 21, 2016 at 7:05 AM, Shawn Guo wrote: > On Tue, Oct 18, 2016 at 05:30:28PM +0530, Jagan Teki wrote: >> Hi Shawn, >> >> On Fri, Oct 14, 2016 at 2:57 PM, Jagan Teki wrote: >> > This is series add dts support for Engicam I.Core M6 qdl modules. just >> > rebased on top of linux-next of previous set[1]. >> > >> > [1] http://www.spinics.net/lists/kernel/msg2358233.html >> > >> > Jagan Teki (5): >> > ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support >> > ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo initial support >> > ARM: dts: imx6qdl-icore: Add usbhost support >> > ARM: dts: imx6qdl-icore: Add usbotg support >> > ARM: dts: imx6qdl-icore: Add FEC support >> > >> > arch/arm/boot/dts/Makefile | 2 + >> > arch/arm/boot/dts/imx6dl-icore.dts | 59 ++++++++ >> > arch/arm/boot/dts/imx6q-icore.dts | 59 ++++++++ >> > arch/arm/boot/dts/imx6qdl-icore.dtsi | 271 +++++++++++++++++++++++++++++++++++ >> > 4 files changed, 391 insertions(+) >> > create mode 100644 arch/arm/boot/dts/imx6dl-icore.dts >> > create mode 100644 arch/arm/boot/dts/imx6q-icore.dts >> > create mode 100644 arch/arm/boot/dts/imx6qdl-icore.dtsi >> >> Can you pick this series? > > Sorry for the delay. The first two patches look good, and I had a > couple of small comments on the other 3. Also, for the initial board > support submission like this, you do not need to split it per device > support. That said, please squash the series into one patch when > resending. Sent v8 by squash the usb host and otg with first patch and second and third one keep separated as one is new board dts and other one though it is FEC support it also have a rmii_clk addition which is kind of new compared to other qdl dtsi files. So please let me know if have any more comments. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.