Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164AbcJUIV6 (ORCPT ); Fri, 21 Oct 2016 04:21:58 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34726 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754294AbcJUIVy (ORCPT ); Fri, 21 Oct 2016 04:21:54 -0400 MIME-Version: 1.0 In-Reply-To: <1476720825-30442-2-git-send-email-javier@osg.samsung.com> References: <1476720825-30442-1-git-send-email-javier@osg.samsung.com> <1476720825-30442-2-git-send-email-javier@osg.samsung.com> From: Ulf Hansson Date: Fri, 21 Oct 2016 10:21:51 +0200 Message-ID: Subject: Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload To: Javier Martinez Canillas Cc: "linux-kernel@vger.kernel.org" , Ludovic Desroches , linux-mmc , Adrian Hunter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1357 Lines: 46 On 17 October 2016 at 18:13, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias > alias: of:N*T*Catmel,sama5d2-sdhciC* > alias: of:N*T*Catmel,sama5d2-sdhci > > Signed-off-by: Javier Martinez Canillas Thanks, applied for next! Kind regards Uffe > --- > > drivers/mmc/host/sdhci-of-at91.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index a9b7fc06c434..2f9ad213377a 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = { > { .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 }, > {} > }; > +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match); > > #ifdef CONFIG_PM > static int sdhci_at91_runtime_suspend(struct device *dev) > -- > 2.7.4 >