Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754737AbcJUKFa (ORCPT ); Fri, 21 Oct 2016 06:05:30 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49165 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753376AbcJUKF2 (ORCPT ); Fri, 21 Oct 2016 06:05:28 -0400 Subject: Re: [PATCH v2 0/8] mm/swap: Regular page swap optimizations To: Tim Chen , Andrew Morton References: Cc: Ying Huang , dave.hansen@intel.com, ak@linux.intel.com, aaron.lu@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Shaohua Li , Minchan Kim , Rik van Riel , Andrea Arcangeli , "Kirill A . Shutemov" , Vladimir Davydov , Johannes Weiner , Michal Hocko , Hillf Danton From: Christian Borntraeger Date: Fri, 21 Oct 2016 12:05:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102110-0040-0000-0000-0000024A9A97 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102110-0041-0000-0000-000022423575 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-21_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610210183 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3164 Lines: 52 On 10/21/2016 10:16 AM, Christian Borntraeger wrote: > On s390 4.9-rc1 + this patch set > I get the following on swapon > > [ 308.206195] ------------[ cut here ]------------ > [ 308.206203] WARNING: CPU: 5 PID: 20745 at mm/page_alloc.c:3511 __alloc_pages_nodemask+0x884/0xdf8 > [ 308.206205] Modules linked in: xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter btrfs raid6_pq xor dm_service_time ghash_s390 prng aes_s390 des_s390 des_generic qeth_l2 sha512_s390 sha256_s390 sha1_s390 sha_common nfsd eadm_sch auth_rpcgss qeth ccwgroup oid_registry nfs_acl lockd grace vhost_net vhost sunrpc macvtap macvlan kvm sch_fq_codel dm_multipath ip_tables > [ 308.206240] CPU: 5 PID: 20745 Comm: swapon Tainted: G W 4.9.0-rc1+ #23 > [ 308.206241] Hardware name: IBM 2964 NC9 704 (LPAR) > [ 308.206243] task: 00000000e3bb8000 task.stack: 00000000d4270000 > [ 308.206244] Krnl PSW : 0704c00180000000 000000000025db3c > [ 308.206246] (__alloc_pages_nodemask+0x884/0xdf8) > > [ 308.206248] R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 > [ 308.206250] RI:0 EA:3 > [ 308.206251] > Krnl GPRS: 000000000000000a 0000000000b2b0ec 0000000100000312 0000000000000001 > [ 308.206267] 000000000025d3ec 0000000000000008 0000000000000075 000000000240c0c0 > [ 308.206269] 0000000000000001 0000000000000000 000000000000000a 0000000000000000 > [ 308.206270] 000000000000000a 000000000079d8c8 000000000025d3ec 00000000d4273ba0 > [ 308.206280] Krnl Code: 000000000025db30: a774fd27 brc 7,25d57e > [ 308.206282] > 000000000025db34: 92011000 mvi 0(%r1),1 > [ 308.206285] > #000000000025db38: a7f40001 brc 15,25db3a > [ 308.206286] > >000000000025db3c: a7f4fd21 brc 15,25d57e > [ 308.206289] > 000000000025db40: 4130f150 la %r3,336(%r15) > [ 308.206291] > 000000000025db44: b904002c lgr %r2,%r12 > [ 308.206293] > 000000000025db48: c0e5ffffe11c brasl %r14,259d80 > [ 308.206294] > 000000000025db4e: a7f4fda3 brc 15,25d694 > [ 308.206297] Call Trace: > [ 308.206299] ([<000000000025d3ec>] __alloc_pages_nodemask+0x134/0xdf8) > [ 308.206303] ([<0000000000280d6a>] kmalloc_order+0x42/0x70) > [ 308.206305] ([<0000000000280dd8>] kmalloc_order_trace+0x40/0xf0) > [ 308.206310] ([<00000000002a7090>] init_swap_address_space+0x68/0x138) > [ 308.206312] ([<00000000002ac858>] SyS_swapon+0xbd0/0xf80) > [ 308.206317] ([<0000000000785476>] system_call+0xd6/0x264) > [ 308.206318] Last Breaking-Event-Address: > [ 308.206319] [<000000000025db38>] __alloc_pages_nodemask+0x880/0xdf8 > [ 308.206320] ---[ end trace aaeca736f47ac05b ]--- > Looks like that 1TB of swap is just too big for your logic (you try kmalloc without checking the size).