Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754909AbcJUKyl (ORCPT ); Fri, 21 Oct 2016 06:54:41 -0400 Received: from mga02.intel.com ([134.134.136.20]:36111 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752203AbcJUKyi (ORCPT ); Fri, 21 Oct 2016 06:54:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,376,1473145200"; d="scan'208";a="1057089515" Message-ID: <1477047272.6423.6.camel@linux.intel.com> Subject: Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported From: Andy Shevchenko To: Luis Oliveira , Wolfram Sang , Ramiro Oliveira Cc: Mark Rutland , jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, CARLOS.PALMINHA@synopsys.com Date: Fri, 21 Oct 2016 13:54:32 +0300 In-Reply-To: <76ab13e9-9aa5-97c3-2328-928bbcef9877@synopsys.com> References: <36f4b1736e36b039af15b13645df0de492f1b6e1.1476462204.git.lolivei@synopsys.com> <20161014173014.GA26269@leverpostej> <20161014182045.GA1509@katana> <55cc91af-8d24-8aea-f74f-2ef40cd8ea5a@synopsys.com> <20161018151706.GA1433@katana> <76ab13e9-9aa5-97c3-2328-928bbcef9877@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1104 Lines: 37 On Fri, 2016-10-21 at 10:56 +0100, Luis Oliveira wrote: > Since practically 90% of the code is shared between master and slave, > I was > thinking if it will be acceptable to use the same driver for both but > differentiate the master/slave mode by the compatible strings. It might be possible to split like other drivers do: 1. Core part (i2c-designware-core.c) 2. Master part (i2c-designware-master.c) 3. Slave part (i2c-designware-slave.c) 4. Glue drivers (like: i2c-designware-platdrv.c) > > Thanks, > Luis > > On 10/18/2016 16:17, Wolfram Sang wrote: > > > This is needed because the configuration is different and the i2c- > > > designware > > > cannot be master/slave without a reset. To resolve that I added > > > this property > > > to bind it as a slave when needed. > > > > Aww, pity that the HW can't do that. Do you have details why? > > > > If that is really a HW limitation, then I'd suggest having a > > seperate > > driver for slave-only mode so we can differentiate by compatible > > strings. > > > > -- Andy Shevchenko Intel Finland Oy