From: Steven Whitehouse <steve@gw.chygwyn.com>
Message-Id: <200305012135.WAA19582@gw.chygwyn.com>
Subject: Re: Remains of seq_file conversion for DECnet, plus fixes
To: hch@infradead.org (Christoph Hellwig)
Date: Thu, 1 May 2003 22:35:46 +0100 (BST)
Cc: davem@redhat.com (David S. Miller),
       linux-decnet-user@lists.sourceforge.net, linux-kernel@vger.kernel.org
In-Reply-To: <20030501215709.A28210@infradead.org> from "Christoph Hellwig" at May 01, 2003 09:57:09 PM
Organization: ChyGywn Limited
Reply-To: Steve Whitehouse <Steve@ChyGwyn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1075
Lines: 36

Hi,

> 
> On Thu, May 01, 2003 at 09:52:01PM +0100, Steven Whitehouse wrote:
> > --- linux-2.5.68-bk10/fs/seq_file.c	Sun Apr 20 03:27:58 2003
> > +++ linux/fs/seq_file.c	Mon Apr 21 14:40:35 2003
> > @@ -338,3 +338,13 @@
> >  	kfree(op);
> >  	return res;
> >  }
> > +
> > +int kfree_release(struct inode *inode, struct file *file)
> > +{
> > +	struct seq_file *seq = file->private_data;
> > +
> > +	kfree(seq->private);
> > +	seq->private = NULL;
> > +	return seq_release(inode, file);
> > +}
> 
> The name is a bit generic for an export function.  What about
> seq_release_kfree?
> 

Yes, I'd considered that and eventually settled for the non-prefixed version
since it followed the pattern set by single_release() which doesn't have
the seq_ prefix. I don't mind changing it though if the prefixed version is
preferred,

Steve.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/