Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933568AbcJUNcZ (ORCPT ); Fri, 21 Oct 2016 09:32:25 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:55899 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933269AbcJUNcX (ORCPT ); Fri, 21 Oct 2016 09:32:23 -0400 Subject: Re: [PATCH 2/2] gpio: ts4800: Fix module autoload To: Linus Walleij References: <1476823442-31104-1-git-send-email-javier@osg.samsung.com> <1476823442-31104-2-git-send-email-javier@osg.samsung.com> Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Alexandre Courbot From: Javier Martinez Canillas Message-ID: Date: Fri, 21 Oct 2016 10:32:14 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 39 Hello Linus, On 10/21/2016 09:55 AM, Linus Walleij wrote: > On Tue, Oct 18, 2016 at 10:44 PM, Javier Martinez Canillas > wrote: > >> If the driver is built as a module, autoload won't work because the module >> alias information is not filled. So user-space can't match the registered >> device with the corresponding module. >> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. >> >> Before this patch: >> >> $ modinfo drivers/gpio/gpio-ts4800.ko | grep alias >> $ >> >> After this patch: >> >> $ modinfo drivers/gpio/gpio-ts4800.ko | grep alias >> alias: of:N*T*Ctechnologic,ts4800-gpioC* >> alias: of:N*T*Ctechnologic,ts4800-gpio >> >> Signed-off-by: Javier Martinez Canillas > > Patch applied for fixes. > Thanks, I guess this also applies to Patch 1/2? > Yours, > Linus Walleij > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America