Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933649AbcJUNit (ORCPT ); Fri, 21 Oct 2016 09:38:49 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35526 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933075AbcJUNir (ORCPT ); Fri, 21 Oct 2016 09:38:47 -0400 MIME-Version: 1.0 In-Reply-To: <20161020181033.GA6375@potion> References: <1476690302-22158-1-git-send-email-wanpeng.li@hotmail.com> <1476690302-22158-6-git-send-email-wanpeng.li@hotmail.com> <20161019192826.GA8573@potion> <20161020181033.GA6375@potion> From: Wanpeng Li Date: Fri, 21 Oct 2016 21:38:44 +0800 Message-ID: Subject: Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Cc: "linux-kernel@vger.kernel.org" , kvm , Paolo Bonzini , Yunhong Jiang , Wanpeng Li Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9LDctNf002731 Content-Length: 803 Lines: 21 2016-10-21 2:10 GMT+08:00 Radim Krčmář : > 2016-10-20 06:57+0800, Wanpeng Li: >> 2016-10-20 3:28 GMT+08:00 Radim Krčmář : >>> I think it would be better to add a function to advance the periodic >>> timer and use it in kvm_lapic_expired_hv_timer() and in apic_timer_fn(). >>> >>> The function can be simpler than set_target_expiration(), because it >>> just adds the period to an existing timer. Periodic timer will also be >>> better then, because the period will not depend on KVM's latency when >>> rearming. >> >> Good point, what's the function name do you like? How about >> advance_target_expiration()? > > Sounds good, I'd just slap periodic somewhere, > advance_periodic_target_expiration()? Cool, thanks for your review. :) Regards, Wanpeng Li