Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933632AbcJUOLk (ORCPT ); Fri, 21 Oct 2016 10:11:40 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:36359 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932861AbcJUOLh (ORCPT ); Fri, 21 Oct 2016 10:11:37 -0400 Subject: Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1476906618-14455-1-git-send-email-javier@osg.samsung.com> Cc: Kevin Hilman , PrasannaKumar Muralidharan , Carlo Caione , linux-amlogic@lists.infradead.org, Herbert Xu , Matt Mackall , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: <29086305-c8a7-ba17-5e99-3a779b9dd410@baylibre.com> Date: Fri, 21 Oct 2016 16:11:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476906618-14455-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 28 On 10/19/2016 09:50 PM, Javier Martinez Canillas wrote: > The Amlogic Meson is a DT-only platform, which means the devices are > registered via OF and not using the legacy platform devices support. > > So there's no need to have a MODULE_ALIAS("platform:meson-rng") since > the reported uevent MODALIAS to user-space will always be the OF one. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/char/hw_random/meson-rng.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c > index 51864a509be7..119d698439ae 100644 > --- a/drivers/char/hw_random/meson-rng.c > +++ b/drivers/char/hw_random/meson-rng.c > @@ -122,7 +122,6 @@ static struct platform_driver meson_rng_driver = { > > module_platform_driver(meson_rng_driver); > > -MODULE_ALIAS("platform:meson-rng"); > MODULE_DESCRIPTION("Meson H/W Random Number Generator driver"); > MODULE_AUTHOR("Lawrence Mok "); > MODULE_AUTHOR("Neil Armstrong "); > Acked-by: Neil Armstrong