Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933887AbcJUO3G (ORCPT ); Fri, 21 Oct 2016 10:29:06 -0400 Received: from mga01.intel.com ([192.55.52.88]:16838 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933068AbcJUO3E (ORCPT ); Fri, 21 Oct 2016 10:29:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,376,1473145200"; d="scan'208";a="775665056" Date: Fri, 21 Oct 2016 17:29:00 +0300 From: Mika Westerberg To: Tobias Klauser Cc: linux-kernel@vger.kernel.org, Jens Axboe Subject: Re: [PATCH] block: Change extern inline to static inline Message-ID: <20161021142900.GY24289@lahna.fi.intel.com> References: <20161021141926.7207-1-tklauser@distanz.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161021141926.7207-1-tklauser@distanz.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 21 On Fri, Oct 21, 2016 at 04:19:26PM +0200, Tobias Klauser wrote: > With compilers which follow the C99 standard (like modern versions of > gcc and clang), "extern inline" does the opposite thing from older > versions of gcc (emits code for an externally linkable version of the > inline function). > > "static inline" does the intended behavior in all cases instead. > > Description taken from commit 6d91857d4826 ("staging, rtl8192e, > LLVMLinux: Change extern inline to static inline"). > > This also fixes the following GCC warning when building with !PM: > ./include/linux/blkdev.h:1143:20: warning: no previous prototype for 'blk_set_runtime_active' [-Wmissing-prototypes] > > Fixes: d07ab6d11477 ("block: Add blk_set_runtime_active()") > Cc: Mika Westerberg Hehe, indeed that "extern" was probably copy pasted from the non-inline declaration. Reviewed-by: Mika Westerberg