Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934025AbcJUOkW (ORCPT ); Fri, 21 Oct 2016 10:40:22 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:34566 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932814AbcJUOkV (ORCPT ); Fri, 21 Oct 2016 10:40:21 -0400 Message-ID: <1477060817.8523.33.camel@gmail.com> Subject: Re: 4.9 regression/bisection - 761ed4a94582 tty: serial_core: convert uart_close to use tty_port_close From: Mike Galbraith To: Rob Herring Cc: LKML , Peter Hurley Date: Fri, 21 Oct 2016 16:40:17 +0200 In-Reply-To: References: <1477053923.8523.13.camel@gmail.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 38 On Fri, 2016-10-21 at 08:51 -0500, Rob Herring wrote: > On Fri, Oct 21, 2016 at 7:45 AM, Mike Galbraith > wrote: > > Greetings, > > > > My old DL980 G7 is exploding on reboot with master, with only the first > > couple lines actually making it to the console. Once (and only once) > > during bisection it did manage to get the below emitted. > > Does this patch[1] fix things for you? Sorry, only the reply seems to > be in the archives. Nope, still went boom. --- drivers/tty/serial/serial_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -2746,8 +2746,6 @@ int uart_add_one_port(struct uart_driver uport->cons = drv->cons; uport->minor = drv->tty_driver->minor_start + uport->line; - port->console = uart_console(uport); - /* * If this port is a console, then the spinlock is already * initialised. @@ -2761,6 +2759,8 @@ int uart_add_one_port(struct uart_driver uart_configure_port(drv, state, uport); + port->console = uart_console(uport); + num_groups = 2; if (uport->attr_group) num_groups++;