Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935555AbcJUPrW (ORCPT ); Fri, 21 Oct 2016 11:47:22 -0400 Received: from imap.thunk.org ([74.207.234.97]:57808 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934306AbcJUPrQ (ORCPT ); Fri, 21 Oct 2016 11:47:16 -0400 Date: Fri, 21 Oct 2016 11:46:24 -0400 From: "Theodore Ts'o" To: SF Markus Elfring Cc: Julia Lawall , linux-hexagon@vger.kernel.org, Richard Kuo , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() Message-ID: <20161021154624.maiwbgjmzlzhin2l@thunk.org> Mail-Followup-To: Theodore Ts'o , SF Markus Elfring , Julia Lawall , linux-hexagon@vger.kernel.org, Richard Kuo , LKML , kernel-janitors@vger.kernel.org References:

MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20160916 (1.7.0) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 16 On Fri, Oct 21, 2016 at 11:00:22AM +0200, SF Markus Elfring wrote: > > > It is harder to see how the arguments fit into the strings > > and it is harder to see where the strings end and the arguments begin. > > Is it really so difficult to interpret the suggested construction > of a single (and relatively small) format string? It's not so difficult, so much as it makes things worse. It's easier the way it originally was. It might be interesting to see if the compiler could be taught to collapse the function calls, but (a) this isn't performance critical, and (b) the number of bytes saved is really tiny. But at least if the compiler was doing the work, it would at least deal with it everywhere. - Ted