Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935259AbcJUPyg (ORCPT ); Fri, 21 Oct 2016 11:54:36 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:51010 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173AbcJUPye (ORCPT ); Fri, 21 Oct 2016 11:54:34 -0400 Date: Fri, 21 Oct 2016 17:54:08 +0200 From: Andrew Lunn To: Neil Armstrong Cc: khilman@baylibre.com, carlo@caione.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH 08/13] dwmac-meson8b: add support for phy selection Message-ID: <20161021155408.GR16974@lunn.ch> References: <1477060838-14164-1-git-send-email-narmstrong@baylibre.com> <1477060838-14164-9-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477060838-14164-9-git-send-email-narmstrong@baylibre.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 453 Lines: 10 On Fri, Oct 21, 2016 at 04:40:33PM +0200, Neil Armstrong wrote: > The Meson GXL dwmac Glue Layer also provides switching between an external PHY > and an internal RMII 10/100 PHY. > Add a way to setup the correct PHY switching from a device tree attribute. Humm, actually. Maybe PHY_IS_INTERNAL in the phydrv->flags is the better solution. The MAC can then use phy_is_internal(ndev->phydev) to decide if this register needs programming. Andrew