Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936201AbcJUTwH (ORCPT ); Fri, 21 Oct 2016 15:52:07 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:53333 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936076AbcJUTwG (ORCPT ); Fri, 21 Oct 2016 15:52:06 -0400 Date: Fri, 21 Oct 2016 21:49:35 +0200 (CEST) From: Thomas Gleixner To: Mason cc: Marc Zyngier , Jason Cooper , LKML , Linux ARM , Sebastian Frias Subject: Re: Disabling an interrupt in the handler locks the system up In-Reply-To: <580A70B9.8060507@free.fr> Message-ID: References: <580A4460.2090306@free.fr> <580A60ED.3030307@free.fr> <20161021201448.3f4a0a7a@arm.com> <580A70B9.8060507@free.fr> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 20 On Fri, 21 Oct 2016, Mason wrote: > On 21/10/2016 21:14, Marc Zyngier wrote: > > If connecting a device that signals its interrupt as level low to an > > input line configured as level high doesn't strike you as a major > > issue, nothing will. At that point, you can put anything you want in > > your DT. > > If I understand correctly, you are saying that I should have > specified IRQ_TYPE_LEVEL_LOW, instead of IRQ_TYPE_LEVEL_HIGH? > > If the HW outputs 1 when idle, and 0 when busy, that > is level low? (Sorry if this is obvious, I'm absolutely > clueless in this subject matter.) We describe the level which is raising the interrupt. So in your case the line goes to 0 when the interrupt is active, so the level is LOW. Thanks, tglx