Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936253AbcJUUCG (ORCPT ); Fri, 21 Oct 2016 16:02:06 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:33490 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936186AbcJUUCE (ORCPT ); Fri, 21 Oct 2016 16:02:04 -0400 Date: Fri, 21 Oct 2016 13:02:00 -0700 From: Eric Biggers To: Richard Weinberger Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, tytso@mit.edu Subject: Re: [PATCH 1/2] fscrypto: Fix log string in do_crypto() Message-ID: <20161021200200.GA137744@google.com> References: <1476824089-6841-1-git-send-email-richard@nod.at> <1476824089-6841-2-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476824089-6841-2-git-send-email-richard@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 31 On Tue, Oct 18, 2016 at 10:54:48PM +0200, Richard Weinberger wrote: > The operations supports both encryption and decryption. > > Signed-off-by: Richard Weinberger > --- > fs/crypto/crypto.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c > index 61057b7dbddb..1637a0450b9f 100644 > --- a/fs/crypto/crypto.c > +++ b/fs/crypto/crypto.c > @@ -194,8 +194,9 @@ static int do_page_crypto(struct inode *inode, > skcipher_request_free(req); > if (res) { > printk_ratelimited(KERN_ERR > - "%s: crypto_skcipher_encrypt() returned %d\n", > - __func__, res); > + "%s: crypto_skcipher_%scrypt() returned %d, flags %#x\n", > + __func__, rw == FS_DECRYPT ? "de" : "en", res, > + crypto_skcipher_get_flags(tfm)); > return res; > } > return 0; > -- > 2.7.3 > Looks fine. Reviewed-by: Eric Biggers