Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936298AbcJUVKt (ORCPT ); Fri, 21 Oct 2016 17:10:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55538 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932989AbcJUVKo (ORCPT ); Fri, 21 Oct 2016 17:10:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 4176D6179F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=spjoshi@codeaurora.org Subject: Re: [PATCH v2 3/4] arm64: dts: msm8996: Add SMEM DT nodes To: Stephen Boyd References: <1477005139-15564-1-git-send-email-spjoshi@codeaurora.org> <1477005139-15564-4-git-send-email-spjoshi@codeaurora.org> <20161021000408.GI26139@codeaurora.org> Cc: Mark Rutland , devicetree@vger.kernel.org, Catalin Marinas , Trilok Soni , Will Deacon , linux-kernel@vger.kernel.org, Bjorn Andersson , David Brown , Rob Herring , linux-arm-msm@vger.kernel.org, Andy Gross , linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Sarangdhar Joshi Message-ID: <52a996ef-a97c-3d6c-0a95-f9e3ebbd2790@codeaurora.org> Date: Fri, 21 Oct 2016 14:10:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161021000408.GI26139@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 51 On 10/20/2016 05:04 PM, Stephen Boyd wrote: > On 10/20, Sarangdhar Joshi wrote: >> From: Bjorn Andersson >> >> Add SMEM and TCSR DT nodes on MSM8996. >> >> Signed-off-by: Bjorn Andersson >> Signed-off-by: Sarangdhar Joshi >> --- >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> index 949b096..abc1089 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> @@ -164,17 +164,36 @@ >> >> }; >> >> + tcsr_mutex: hwlock { >> + compatible = "qcom,tcsr-mutex"; >> + syscon = <&tcsr_mutex_regs 0 0x1000>; >> + #hwlock-cells = <1>; >> + }; >> + >> psci { >> compatible = "arm,psci-1.0"; >> method = "smc"; >> }; >> >> + smem { >> + compatible = "qcom,smem"; >> + >> + memory-region = <&smem_mem>; >> + >> + hwlocks = <&tcsr_mutex 3>; > > Super nitpick: Is there a reason we have newlines between > everything in this node? This node is the only one that isn't > consistent. Thanks, will do that. I think I just missed updating this node from original patchset. > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project