Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755883AbcJVBsB (ORCPT ); Fri, 21 Oct 2016 21:48:01 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:48825 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755480AbcJVBsA (ORCPT ); Fri, 21 Oct 2016 21:48:00 -0400 From: Lipengcheng To: Felipe Balbi , "johnyoun@synopsys.com" CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Xuejiancheng , Lidongpo , Caizhiyong Subject: RE: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting Thread-Topic: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting Thread-Index: AQHSFZd6Mj4Nkv19302htiMoA0bvv6CsAsUAgAbGzwA= Date: Sat, 22 Oct 2016 01:44:20 +0000 Message-ID: <637796ED17F7774FB27D6AAE3C6951584A94A8BB@SZXEMA509-MBS.china.huawei.com> References: <1474634096-106548-1-git-send-email-lpc.li@hisilicon.com> <87vawrs4e1.fsf@linux.intel.com> In-Reply-To: <87vawrs4e1.fsf@linux.intel.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.223.197] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9M1mSkV006280 Content-Length: 1050 Lines: 33 > -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com] > Sent: Monday, October 17, 2016 5:37 PM > To: Lipengcheng; johnyoun@synopsys.com > Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Xuejiancheng; Lidongpo; Caizhiyong; Lipengcheng > Subject: Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting > > > Hi, > > Pengcheng Li writes: > > The USBTRDTIM field needs to be cleared before setting a new value. > > Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8. > > > > Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f > > Signed-off-by: Pengcheng Li > > Acked-by: John Youn > > which commit are you fixing? Seems like you're missing a: > commit c45574ff02d1d1f35a6bf4b8ad051fc06c001fc7. > Fixes: foobar .... > > line here. Also, you need to remove Gerritisms from commit log ;-) > Ok, I will remove at the next patch. > -- > Balbi Best Regards Pengcheng Li