Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756227AbcJVIjZ (ORCPT ); Sat, 22 Oct 2016 04:39:25 -0400 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:64145 "EHLO SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753568AbcJVIjW (ORCPT ); Sat, 22 Oct 2016 04:39:22 -0400 X-Greylist: delayed 1067 seconds by postgrey-1.27 at vger.kernel.org; Sat, 22 Oct 2016 04:39:20 EDT Date: Sat, 22 Oct 2016 16:14:49 +0800 From: Xiaolong Zhang To: Stephen Boyd CC: , , , , , Subject: Re: [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks Message-ID: <20161022081448.GB32560@spreadtrum.com> References: <1476184424-8528-1-git-send-email-orson.zhai@spreadtrum.com> <20161020230103.GD26139@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161020230103.GD26139@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-MAIL: SHSQR01.spreadtrum.com u9M8KRS0096271 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 24 On ε››, 10月 20, 2016 at 04:01:03δΈ‹εˆ -0700, Stephen Boyd wrote: > On 10/11, Orson Zhai wrote: > > From: Xiaolong Zhang > > > > When common kernel setups fixed clock, of_clk_provider will be registerred. > > But there is no clkdev being registerred at the same time. This will make > > it difficult to get the clock by using clk_get(NULL, con_id). > > > > Add clkdev register for fixed-rate and fixed-factor clock and ignore > > the error if any. > > > > Signed-off-by: Xiaolong Zhang > > Signed-off-by: Orson Zhai > > --- > > Why are we using clkdev lookups for clks populated from DT? > Shouldn't we be able to point to them from the consumers that > would also be in DT? I'm a little lost. > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project The clk_get interface allows the first argument as NULL. We just assure consumers can get the clock from DT or by clock name.