Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936677AbcJVItZ (ORCPT ); Sat, 22 Oct 2016 04:49:25 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:36853 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932826AbcJVItW (ORCPT ); Sat, 22 Oct 2016 04:49:22 -0400 From: Baoyou Xie To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, nicolai.haehnle@amd.com, Jammy.Zhou@amd.com, Qingqing.Wang@amd.com, daniel.vetter@ffwll.ch, tom.stdenis@amd.com, michel.daenzer@amd.com, gustavo.padovan@collabora.co.uk, eric.engestrom@imgtec.com, Emily.Deng@amd.com, David1.Zhou@amd.com, CARLOS.PALMINHA@synopsys.com, ville.syrjala@linux.intel.com, Flora.Cui@amd.com, vitaly.prosyak@amd.com, alexandre.f.demers@gmail.com, Jerry.Zhang@amd.com, Rex.Zhu@amd.com, funfunctor@folklore1984.net Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 2/3] drm/amdgpu: mark symbols static where possible Date: Sat, 22 Oct 2016 16:48:26 +0800 Message-Id: <1477126107-2466-2-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477126107-2466-1-git-send-email-baoyou.xie@linaro.org> References: <1477126107-2466-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 37 We get 2 warnings when building kernel with W=1: drivers/gpu/drm/amd/amdgpu/si.c:908:5: warning: no previous prototype for 'si_pciep_rreg' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/si.c:921:6: warning: no previous prototype for 'si_pciep_wreg' [-Wmissing-prototypes] In fact, both functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/amd/amdgpu/si.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index dc9511c..bacdff8 100644 --- a/drivers/gpu/drm/amd/amdgpu/si.c +++ b/drivers/gpu/drm/amd/amdgpu/si.c @@ -905,7 +905,7 @@ static void si_pcie_wreg(struct amdgpu_device *adev, u32 reg, u32 v) spin_unlock_irqrestore(&adev->pcie_idx_lock, flags); } -u32 si_pciep_rreg(struct amdgpu_device *adev, u32 reg) +static u32 si_pciep_rreg(struct amdgpu_device *adev, u32 reg) { unsigned long flags; u32 r; @@ -918,7 +918,7 @@ u32 si_pciep_rreg(struct amdgpu_device *adev, u32 reg) return r; } -void si_pciep_wreg(struct amdgpu_device *adev, u32 reg, u32 v) +static void si_pciep_wreg(struct amdgpu_device *adev, u32 reg, u32 v) { unsigned long flags; -- 2.7.4