Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936614AbcJVJap (ORCPT ); Sat, 22 Oct 2016 05:30:45 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:44944 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935727AbcJVJan (ORCPT ); Sat, 22 Oct 2016 05:30:43 -0400 X-Originating-IP: 1.129.34.51 Subject: Re: [PATCH 1/3] drm/amdgpu: change function declarations and add missing header dependencies To: Baoyou Xie , alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, nicolai.haehnle@amd.com, Jammy.Zhou@amd.com, Qingqing.Wang@amd.com, daniel.vetter@ffwll.ch, tom.stdenis@amd.com, michel.daenzer@amd.com, gustavo.padovan@collabora.co.uk, eric.engestrom@imgtec.com, Emily.Deng@amd.com, David1.Zhou@amd.com, CARLOS.PALMINHA@synopsys.com, ville.syrjala@linux.intel.com, Flora.Cui@amd.com, vitaly.prosyak@amd.com, alexandre.f.demers@gmail.com, Jerry.Zhang@amd.com, Rex.Zhu@amd.com References: <1477126107-2466-1-git-send-email-baoyou.xie@linaro.org> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn From: "Edward O'Callaghan" Message-ID: Date: Sat, 22 Oct 2016 20:30:20 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477126107-2466-1-git-send-email-baoyou.xie@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9cPgNde1HPu6EunboHPlkv1XRcE0Q3cLm" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 8277 Lines: 212 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9cPgNde1HPu6EunboHPlkv1XRcE0Q3cLm Content-Type: multipart/mixed; boundary="AU8NGKa8PnXFT9QVeLeSk4tart6hpeIAs"; protected-headers="v1" From: Edward O'Callaghan To: Baoyou Xie , alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, nicolai.haehnle@amd.com, Jammy.Zhou@amd.com, Qingqing.Wang@amd.com, daniel.vetter@ffwll.ch, tom.stdenis@amd.com, michel.daenzer@amd.com, gustavo.padovan@collabora.co.uk, eric.engestrom@imgtec.com, Emily.Deng@amd.com, David1.Zhou@amd.com, CARLOS.PALMINHA@synopsys.com, ville.syrjala@linux.intel.com, Flora.Cui@amd.com, vitaly.prosyak@amd.com, alexandre.f.demers@gmail.com, Jerry.Zhang@amd.com, Rex.Zhu@amd.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Message-ID: Subject: Re: [PATCH 1/3] drm/amdgpu: change function declarations and add missing header dependencies References: <1477126107-2466-1-git-send-email-baoyou.xie@linaro.org> In-Reply-To: <1477126107-2466-1-git-send-email-baoyou.xie@linaro.org> --AU8NGKa8PnXFT9QVeLeSk4tart6hpeIAs Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable This series is, Acked-by: Edward O'Callaghan On 10/22/2016 07:48 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=3D1: > drivers/gpu/drm/amd/amdgpu/atombios_crtc.c:38:6: warning: no previous p= rototype for 'amdgpu_atombios_crtc_overscan_setup' [-Wmissing-prototypes]= > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:661:6: warning: no previous proto= type for 'dce_v8_0_disable_dce' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:40:5: warning: no previous prot= otype for 'amdgpu_gfx_scratch_get' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:62:6: warning: no previous prot= otype for 'amdgpu_gfx_scratch_free' [-Wmissing-prototypes] > .... >=20 > In fact, these functions are declared in > drivers/gpu/drm/amd/amdgpu/atombios_crtc.h > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > drivers/gpu/drm/amd/amdgpu/dce_v8_0.h > drivers/gpu/drm/amd/amdgpu/dce_v10_0.h > drivers/gpu/drm/amd/amdgpu/dce_v11_0.h > drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h. > So this patch adds missing header dependencies. >=20 > By the way, this patch changes declaration of amdgpu_gfx_parse_disable_= cu() > to subject to its implement, and clean three function declarations > in pp_acpi.h up. >=20 > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 ++- > drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 + > drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 + > drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c | 1 + > drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h | 9 +++------ > 8 files changed, 11 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_gfx.c > index a074edd..01a42b6 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c > @@ -24,6 +24,7 @@ > */ > #include > #include "amdgpu.h" > +#include "amdgpu_gfx.h" > =20 > /* > * GPU scratch registers helpers function. > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/= amd/amdgpu/amdgpu_gfx.h > index 51321e1..abd9432 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h > @@ -27,6 +27,7 @@ > int amdgpu_gfx_scratch_get(struct amdgpu_device *adev, uint32_t *reg);= > void amdgpu_gfx_scratch_free(struct amdgpu_device *adev, uint32_t reg)= ; > =20 > -unsigned amdgpu_gfx_parse_disable_cu(unsigned *mask, unsigned max_se, = unsigned max_sh); > +void amdgpu_gfx_parse_disable_cu(unsigned int *mask, unsigned int max_= se, > + unsigned int max_sh); > =20 > #endif > diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c b/drivers/gpu/d= rm/amd/amdgpu/atombios_crtc.c > index f7d236f..8c9bc75 100644 > --- a/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c > +++ b/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c > @@ -31,6 +31,7 @@ > #include "atom.h" > #include "atom-bits.h" > #include "atombios_encoders.h" > +#include "atombios_crtc.h" > #include "amdgpu_atombios.h" > #include "amdgpu_pll.h" > #include "amdgpu_connectors.h" > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/a= md/amdgpu/dce_v10_0.c > index 4108c68..443b35f 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c > @@ -31,6 +31,7 @@ > #include "atombios_encoders.h" > #include "amdgpu_pll.h" > #include "amdgpu_connectors.h" > +#include "dce_v10_0.h" > =20 > #include "dce/dce_10_0_d.h" > #include "dce/dce_10_0_sh_mask.h" > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/a= md/amdgpu/dce_v11_0.c > index f264b8f..d58638c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c > @@ -31,6 +31,7 @@ > #include "atombios_encoders.h" > #include "amdgpu_pll.h" > #include "amdgpu_connectors.h" > +#include "dce_v11_0.h" > =20 > #include "dce/dce_11_0_d.h" > #include "dce/dce_11_0_sh_mask.h" > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/am= d/amdgpu/dce_v8_0.c > index 5966166..dd5838c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > @@ -31,6 +31,7 @@ > #include "atombios_encoders.h" > #include "amdgpu_pll.h" > #include "amdgpu_connectors.h" > +#include "dce_v8_0.h" > =20 > #include "dce/dce_8_0_d.h" > #include "dce/dce_8_0_sh_mask.h" > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c b/drivers/gp= u/drm/amd/powerplay/hwmgr/pp_acpi.c > index 1944d28..f5e8fda 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c > @@ -25,6 +25,7 @@ > #include "linux/delay.h" > #include "hwmgr.h" > #include "amd_acpi.h" > +#include "pp_acpi.h" > =20 > bool acpi_atcs_functions_supported(void *device, uint32_t index) > { > diff --git a/drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h b/drivers/gpu/= drm/amd/powerplay/inc/pp_acpi.h > index 3df5de2..8fe8ba9 100644 > --- a/drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h > +++ b/drivers/gpu/drm/amd/powerplay/inc/pp_acpi.h > @@ -21,9 +21,6 @@ > * > */ > =20 > -extern bool acpi_atcs_functions_supported(void *device, > - uint32_t index); > -extern int acpi_pcie_perf_request(void *device, > - uint8_t perf_req, > - bool advertise); > -extern bool acpi_atcs_notify_pcie_device_ready(void *device); > +bool acpi_atcs_functions_supported(void *device, uint32_t index); > +int acpi_pcie_perf_request(void *device, uint8_t perf_req, bool advert= ise); > +bool acpi_atcs_notify_pcie_device_ready(void *device); >=20 --AU8NGKa8PnXFT9QVeLeSk4tart6hpeIAs-- --9cPgNde1HPu6EunboHPlkv1XRcE0Q3cLm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYCzGsAAoJEP4bvbfZuWjbM50QAM+61RT+6bsOU/Nj0XuxZ+f2 76lCrNtzF6okpq6b6wgzc/ZFK7aIFKbgjaegbtOAgC2ZVWnbO/2BTyszdj/IWtRE FnwBxTdhvzVimzNJLhykf9dMdS219SPAn49mP5i4yVzVrBUlgF9RrgkKWjMOQt3M NUpPQTxL+mbG3nWU3j8vumpbzQCZiEK1TLNQ9i9gsRE4UfIR5mo+eESP1pEl0qk1 ZSzUAv4wFK2xUozkDIUeNxTR6Azv2qebaPEJn02Aho8pesZneAPbq2Yf0kNu6u3f E6invQtxzjIU/TKIhgX6t5pvD/vzjIk7UmTm+dK6QDcBtp1odlzR5nV2K2VII8QC iiddE3Kl+m0vwfEhZAIjK5ZavtQykb4C9NbE4ZO3JB2D9cCzBvqeV3UZOND4vRdl 8YuG0PZ5kvxqdx4EkIGq1yeH0c4Vv9Bus4dkHc1czEpizq6BOBsl5nceg1U8S/A3 tHm+Gs4sBE6JjHwTN3SspVhWgDe5zrepVsZGj+od/ckuifCD6eLXYd8Hd3PCjdoV 4LlyOg4tRxIXwOYaREJdRZlnw8Tx6RpyqfUw/Oz7y1MdVq/9fqOScrcc0GLYzte+ vrUsi7+etycm+9kO8DBHdE4NfDuSHVwtr6nd0L+q4bJZk/JlvygxJJyDEHyrTint S8kx+cAlJH/3BFC9KAwm =7CtH -----END PGP SIGNATURE----- --9cPgNde1HPu6EunboHPlkv1XRcE0Q3cLm--