Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938640AbcJVOhx (ORCPT ); Sat, 22 Oct 2016 10:37:53 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33995 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934263AbcJVOhv (ORCPT ); Sat, 22 Oct 2016 10:37:51 -0400 From: Wei Yongjun To: Christine Caulfield , David Teigland Cc: Wei Yongjun , cluster-devel@redhat.com, linux-kernel@vger.kernel.org Subject: [PATCH -next] dlm: fix error return code in sctp_accept_from_sock() Date: Sat, 22 Oct 2016 14:37:36 +0000 Message-Id: <1477147056-2681-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 26 From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- fs/dlm/lowcomms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index df680a2..7d398d3 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -879,7 +879,8 @@ static int sctp_accept_from_sock(struct connection *con) } make_sockaddr(&prim.ssp_addr, 0, &addr_len); - if (addr_to_nodeid(&prim.ssp_addr, &nodeid)) { + ret = addr_to_nodeid(&prim.ssp_addr, &nodeid); + if (ret) { unsigned char *b = (unsigned char *)&prim.ssp_addr; log_print("reject connect from unknown addr");