Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964787AbcJVO5l (ORCPT ); Sat, 22 Oct 2016 10:57:41 -0400 Received: from mail.kernel.org ([198.145.29.136]:48960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935509AbcJVO5j (ORCPT ); Sat, 22 Oct 2016 10:57:39 -0400 Date: Sat, 22 Oct 2016 09:57:33 -0500 From: Bjorn Helgaas To: Sinan Kaya Cc: linux-acpi@vger.kernel.org, rjw@rjwysocki.net, bhelgaas@google.com, ravikanth.nalla@hpe.com, linux@rainbow-software.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, alex.williamson@redhat.com, Len Brown , x86@kernel.org, "H. Peter Anvin" , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, agross@codeaurora.org, linux-kernel@vger.kernel.org, Ingo Molnar , Pavel Machek , linux-arm-msm@vger.kernel.org, wim@djo.tudelft.nl, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function" Message-ID: <20161022145733.GI9007@localhost> References: <1476915664-27231-1-git-send-email-okaya@codeaurora.org> <1476915664-27231-3-git-send-email-okaya@codeaurora.org> <20161021015814.GC31044@localhost> <20161021144535.GB877@localhost> <2a824792-486a-6251-4931-c5cc6fd67978@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a824792-486a-6251-4931-c5cc6fd67978@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 24 On Fri, Oct 21, 2016 at 09:13:06AM -0700, Sinan Kaya wrote: > On 10/21/2016 7:45 AM, Bjorn Helgaas wrote: > > [1] http://marc.info/?l=linux-acpi&m=145580159209240&w=2) > > > >> > Acked-by: Bjorn Helgaas > > Wait a minute, I still have a question here: what about other ACPI > > arches (ia64, arm64)? Don't they need to call acpi_penalize_sci_irq() > > somewhere? > > > > ACPI ARM64 architecture implements reduced ACPI profile which doesn't > have GED object. Instead, ARM64 architecture uses onchip peripherals > for similar functionality. If there is a need to signal interrupts, > this is done by ACPI Notify in ASL or if absolutely needed using > ACPI Generic Event Device (GED). OK. I guess ia64 never did call acpi_penalize_sci_irq(), so while it could be added someday to unify things, we don't need to add it now. Same for arm64. So I'd like it if you updated the changelog, but I'm OK with the patch: Acked-by: Bjorn Helgaas