Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964985AbcJVRaA (ORCPT ); Sat, 22 Oct 2016 13:30:00 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:53760 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964922AbcJVR35 (ORCPT ); Sat, 22 Oct 2016 13:29:57 -0400 Subject: Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions To: Dan Carpenter , Brian Masney References: <1476873130-24926-1-git-send-email-masneyb@onstation.org> <1476873130-24926-6-git-send-email-masneyb@onstation.org> <20161019113345.GJ4469@mwanda> <20161019113731.GF4418@mwanda> Cc: devel@driverdev.osuosl.org, lars@metafoo.de, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de From: Jonathan Cameron Message-ID: Date: Sat, 22 Oct 2016 18:29:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161019113731.GF4418@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 16 On 19/10/16 12:37, Dan Carpenter wrote: > I appologize for laughing, but I am still secretly amused in my heart. > > regards, > dan carpenter > Fewer beers or less caffeine for Dan! Key take away here is keep things simple. The gotos in my mind would actually have made sense, but I wouldn't do the refactoring until you need it. i.e. when you introduce the locking in this patch. > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >